Skip to content

Anonymize evaluation staff notes #2698 - #2721

Open
anjaton wants to merge 3 commits into
e-valuation:mainfrom
anjaton:AnonymizeEvaluationStaffNotes
Open

Anonymize evaluation staff notes #2698#2721
anjaton wants to merge 3 commits into
e-valuation:mainfrom
anjaton:AnonymizeEvaluationStaffNotes

Conversation

@anjaton

@anjaton anjaton commented May 4, 2026

Copy link
Copy Markdown
Collaborator

fixes #2698

@anjaton anjaton changed the title Anonymizeevaluationstaffnotes#2698 Anonymize evaluation staff notes #2698 May 4, 2026
Comment thread evap/evaluation/management/commands/anonymize.py Outdated
course=cls.course,
name_de="Wie man Software testet",
name_en="Testing your software",
staff_notes="This evaluation has dropout answers",

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a bit of a misleading note because this is not the case in this test, can we use something else?

@github-actions github-actions Bot added the Stale label Jul 7, 2026
@niklasmohrin

Copy link
Copy Markdown
Member

@anjaton do you want to keep working on this, or should we take over / assign this issue to someone else?

Co-authored-by: Niklas Mohrin <dev@niklasmohrin.de>
@anjaton

anjaton commented Jul 27, 2026

Copy link
Copy Markdown
Collaborator Author

I thought it was finished. DO I have to accept the suggested changes? Sorry i didnt know that. If there is something left to do you can take over.

@niklasmohrin

Copy link
Copy Markdown
Member

The way it usually works is that we reviewers give some feedback comments that the PR author then incorporates into the PR (this can be done by just pushing more commits to the branch). The author can then click "resolve" on all these comments and re-request a review on Github in the reviewers list on the right. (For PRs from new contributors, we keep an eye out on them ourselves and check in every now and then) And at all times, you can reach out by writing a comment with any questions or problems. Once the reviewers are happy with the PR, we merge it so that the changes are also present in the main branch of the e-valution/EvaP repository and included in the next release; it will look like in your other PR: https://redirect.github.com/e-valuation/EvaP/pull/2700 :)

So for this PR, there currently is one unresolved comment by me, which suggests that we change the value of staff_notes in the test, because its content is a bit misleading: #2721 (comment) You can either fix this yourself (it should be only a small change), or we can just pick it up ourselves on Monday

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Development

Successfully merging this pull request may close these issues.

Anonymize evaluation staff notes

3 participants